Mimir delete heartbeat alertmanager configs #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: QuentinBisson <[email protected]>
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
mimir-delete-heartbeat-alertmanager-configs
branch
from
3d129d7 to
7676c42
Compare
TheoBrigitte
approved these changes
Jun 3, 2024
|
Tested on grizzly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3218 and a follow up of #1631 this PR gets rids of olds heartbeat wiring when Mimir is enabled.
The PR is big because the changed required moving away from the generic resource which probably should never have been a thing :D
Checklist
I have:
CHANGELOG.md